feat: route jenkins/circleci through cigen, retire template generators (#804)#21
Merged
Conversation
…s; bump workflow v0.68.0 (#804)
…erate), plugin v0.2.0 (#804)
…assert smoke+secret in cigen tests (PR2 review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR 2 of 3 for #804. Routes the plugin's
jenkinsandcircleciplatforms through the workflow engine's config-derivedcigenrenderers (shipped in workflow v0.68.0, PR #810) and retires the legacytext/templategenerators. All fourstep.ci_generateplatforms are now config-derived from the sameCIPlan.Satisfies acceptance #2:
step.ci_generatefor jenkins/circleci routes through cigen; jenkins/circleci template generators removed.Changes
go.mod— bumpgithub.com/GoCodeAlone/workflowv0.67.0 → v0.68.0 (first release withcigen.RenderJenkins/RenderCircleCI).plugin.json minEngineVersion→ 0.68.0.internal/generator.go— the platform switch routes all four platforms throughcigen(4-way render switch). Deleted: theregistrymap, theGeneratorinterface, the legacydefault:template branch, and theinternal/platformsimport.internal/platforms/(9 files) — jenkins/circleci template generators plus the GHA/GitLab template files that were already off the production path since feat: smart GHA/GitLab generation via cigen (PR5/7) #18 (their tests were the only remaining referees). Intentional full-package retirement.internal/generator_test.go— replaced the two_TemplateUnchangedtests with_CigenMarkerstests (realExecuteCIGenerate→ config-derived markers: secret wiring,wfctl migrations up, smoke,wfctl infra apply; absence ofgo test/wfctl deploy --image/docker buildper ADR 0044). Path-safety preserved via a directvalidateRelativeOutputPathunit test (the registry-injection seam is gone); deletedstaticGenerator/registerTestGenerator.integration_test.go—TestIntegration_ExecuteCIGenerate_JenkinsCircleCIdrives the realExecuteCIGeneratefor both platforms across the external package boundary (acceptance fix: use released workflow dependency #2 behavior proof). Existing pipeline-wiring mock tests retained.plugin.json— version 0.1.6 → 0.2.0 (behavior change: jenkins/circleci now config-derived).README.md— corrected (all four platforms config-derived).Verification
go test ./...— PASS (root + internal)._CigenMarkersfor all 4 platforms + the real-ExecuteCIGenerateintegration test green.go vet ./...— clean.golangci-lint run --new-from-rev=origin/main ./...— 0 issues.<dir>/ci-generator/ci-generator+plugin.json).Sequencing
Depends on workflow v0.68.0 (merged + tagged). After merge: tag plugin v0.2.0.
Note
Copilot review intentionally not requested (broken). Merge gate = adversarial review clean + two-stage code review APPROVED + CI green.
🤖 Generated with Claude Code