fix: reject padded component refs#35
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR tightens protocol validation by rejecting component_ref values that include any leading/trailing whitespace (rather than silently trimming), and adds regression tests to ensure service and node-service workloads enforce the stricter behavior.
Changes:
- Reject
component_refvalues with surrounding whitespace in both provider-specific and generic component-ref validators. - Preserve existing “no whitespace/NUL anywhere” rules while preventing whitespace-padding from being accepted via trimming.
- Add regression tests covering whitespace-padded
component_refforServiceWorkloadandNodeServiceWorkload.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
protocol/types.go |
Updates component ref validation to reject surrounding whitespace before further validation. |
protocol/types_test.go |
Adds service and node-service regression tests ensuring padded component_ref is rejected. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Adversarial Review