feat: support product capture workloads#2
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for submitting/dispatching the new product-capture compute workload type, including CLI ergonomics and regression tests, and updates the workflow-compute dependency to a protocol/provider revision that includes product-capture support.
Changes:
- Added dispatch step tests covering acceptance of
product-captureworkloads and strict rejection of unknown nestedproduct_capturefields. - Added
wfctl compute submit product-capturesubcommand to construct/validate and submit product-capture tasks. - Updated
github.com/GoCodeAlone/workflow-computedependency (and indirectpgx) to pick up the product-capture protocol/provider updates.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/steps_test.go | Adds coverage for dispatch step handling of product-capture workload config and strict decoding behavior. |
| internal/cli.go | Implements compute submit product-capture command and wires it into wfctl compute submit. |
| internal/cli_test.go | Adds CLI test ensuring product-capture submit emits a compact receipt and does not leak request details. |
| go.mod | Bumps workflow-compute dependency (and pgx indirect) to versions containing product-capture support. |
| go.sum | Updates checksums consistent with the module version bumps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0cc97ec to
67b6127
Compare
67b6127 to
48b68e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation