ci: canonical registry notify (fix dead dispatch + drop manifest-overwrite)#22
Merged
Merged
Conversation
Replace dead notify-registry job (REGISTRY_PAT + full repo name payload) with fleet-canonical notify-workflow-registry job: pinned peter-evans/ repository-dispatch@v4 SHA, repo_dispatch_token secret, bare plugin name "discord" payload, and pre-release/fork guard conditions. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the release workflow to reliably notify the central workflow-registry when this plugin is released, using the canonical dispatch mechanism and safer guards.
Changes:
- Replaces the old
notify-registryjob (dead secret + silent failure) withnotify-workflow-registryusingsecrets.repo_dispatch_token. - Sends a simplified dispatch payload (
{"plugin":"discord","tag":"..."}) and pinspeter-evans/repository-dispatchto a v4 commit SHA. - Adds guards to avoid running on tag deletions, pre-releases, and forks; removes
continue-on-errorto surface failures.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
notify-registryjob (using deadREGISTRY_PATsecret and full repo-name payload) with fleet-canonicalnotify-workflow-registryjob.Changes:
repo_dispatch_token(the live fleet secret)"discord"(notgithub.repository) so the registry consumer doesn't need to parse/strip the org prefixpeter-evans/repository-dispatchto SHA (v4)!contains(github.ref_name, '-')+github.repository == '...')continue-on-error: true(silent failures hidden the dead dispatch)