Skip to content

chore: declare secret target support#24

Merged
intel352 merged 2 commits into
mainfrom
feat/secret-target-model
Jun 8, 2026
Merged

chore: declare secret target support#24
intel352 merged 2 commits into
mainfrom
feat/secret-target-model

Conversation

@intel352

@intel352 intel352 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • declare supported secret_targets[] for plugin required secrets
  • include GitHub Actions, GitLab CI/CD variables, Vault, file, keychain, and explicit local env targets

Verification

  • jq empty plugin.json
  • git diff --check

Copilot AI review requested due to automatic review settings June 8, 2026 17:39

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the plugin manifest to declare supported secret storage/target backends for the plugin’s required secrets, aiming to make secret-management expectations explicit for different runtime environments.

Changes:

  • Add a new top-level secret_targets array to plugin.json describing supported providers/scopes (GitHub, GitLab, Vault, file, keychain, env).
  • Extend manifest metadata to include human-readable descriptions for each declared secret target.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread plugin.json Outdated
Comment on lines +163 to +165
],
"secret_targets": [
{
Comment thread plugin.json Outdated
Comment on lines +164 to +172
"secret_targets": [
{
"provider": "github",
"scopes": [
"repo",
"env",
"org"
],
"description": "Stored as GitHub Actions secrets when workflows run on GitHub."
@intel352 intel352 merged commit 61a8e24 into main Jun 8, 2026
4 checks passed
@intel352 intel352 deleted the feat/secret-target-model branch June 8, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants