Skip to content

chore: apply plugin version discipline#16

Merged
intel352 merged 1 commit into
mainfrom
issue-760-version-discipline
Jun 1, 2026
Merged

chore: apply plugin version discipline#16
intel352 merged 1 commit into
mainfrom
issue-760-version-discipline

Conversation

@intel352
Copy link
Copy Markdown
Contributor

@intel352 intel352 commented Jun 1, 2026

Part of GoCodeAlone/workflow#760.

Changes:

  • keep committed plugin.json.version at the 0.0.0 development sentinel
  • remove the obsolete sync-plugin-version workflow when present
  • add post-build release validation so the shipped manifest is checked against the tag

Verification:

  • wfctl plugin validate-contract .
  • wfctl plugin validate-contract --for-publish --tag v9.9.9 .
  • GOWORK=off go test ./...

Copilot AI review requested due to automatic review settings June 1, 2026 17:34
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Applies plugin version discipline by resetting the committed plugin.json version to the development sentinel and adding a post-build validation step in the release workflow to ensure the shipped manifest carries the release tag.

Changes:

  • Reset plugin.json version from 1.0.2 back to the 0.0.0 development sentinel.
  • Add a post-build wfctl plugin validate-contract --for-publish step in release.yml that checks the shipped manifest against github.ref_name and the release dir.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
plugin.json Reverts version field to the 0.0.0 sentinel so the source of truth for releases is the git tag.
.github/workflows/release.yml Adds a post-build validate-contract step verifying the shipped plugin.json against the pushed tag.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@intel352 intel352 merged commit 760e874 into main Jun 1, 2026
3 checks passed
@intel352 intel352 deleted the issue-760-version-discipline branch June 1, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants