refactor: extract pkg/hoverclient for cross-repo reuse (closes #25)#26
Merged
Conversation
Move HTML-scrape Hover client (582 LOC stdlib HTTP + TOTP) from internal/hover/ to pkg/hoverclient/ so workflow-plugin-infra (and any future consumer) can import without copy-pasting. - Package renamed hover → hoverclient. - Public surface unchanged: Credentials, NewClient, Login, Domain, DNSRecord, DomainDelegation, ListRecords, CreateRecord, UpdateRecord, DeleteRecord, GetDomain, GetDomainDelegation, SetNameservers, TOTPSecret, ParseBase32. - 4 internal callers updated (provider.go, drivers/dns.go, drivers/delegation.go + 2 test files). - Plugin Name() still returns "hover" (string literal — not package name). Closes #25. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves HTML-scrape Hover client from
internal/hover/topkg/hoverclient/so workflow-plugin-infra (and future consumers) can import without copy-pasting 582 LOC. Closes #25.Scope
hover→hoverclientCredentials,NewClient,DNSRecord, etc.)Name()still returns "hover" (string literal, not package name)Test plan
GOWORK=off go test ./...— all PASSGOWORK=off go vet ./...— cleanConsumer: workflow-plugin-infra DNS provider v2 Task 6 (Hover adapter) unblocks on this + tag.
🤖 Generated with Claude Code