test(hover): add live no-op nameserver write probe#37
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an env-gated live “no-op” write probe to validate the Hover browser backend’s SetNameservers path end-to-end (read → write same value → read).
Changes:
- Introduces
TestLiveSetNameserversNoop, gated byHOVER_LIVE_TEST=1plus domain/expected-nameserver env vars. - Adds small helpers to parse and normalize nameserver lists for stable comparisons in the live test.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an env-gated live test for the Hover browser write path. The test refuses to write unless HOVER_LIVE_NS_DOMAIN and HOVER_LIVE_NS_EXPECTED are supplied, verifies the current registrar nameservers match the expected no-op value, calls SetNameservers with that same value, and verifies the post-read still matches.\n\nVerification:\n- GOWORK=off go test ./pkg/hoverclient -run TestLiveSetNameserversNoop -count=1 -v\n- GOWORK=off go test ./... -count=1\n\nRuntime validation to run from GoCodeAlone/gocodealone-dns after this branch is available:\n- hover_ref=codex/live-setnameservers-noop\n- run_write_probe=true\n- write_probe_domain=coredump.computer\n- expected_nameservers=ns1.hover.com,ns2.hover.com