refactor: strip libdns + admincli + dns packages + remove dns_record step (Phase 3b)#25
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 3b of cross-repo DNS cascade. workflow-plugin-infra becomes a thin abstract-module-types-only plugin. Pairs with PR 7 in workflow (already merged): the dns-policy commands, dns/policy + dns/gate + dns/audit packages, and OnBeforeAction hook all live in workflow now.
Two commits:
Changes
Test surface delta
Verification
```
GOWORK=off go build ./...
GOWORK=off go test ./...
```
Both green. `grep` for any remaining `workflow-plugin-infra/internal/{admincli,dnsprovider,dnspolicy,dnsgate,dnsaudit}` import returns zero in-repo hits.
Rollback
Revert THIS PR first, then PR 7 (workflow#787) — order matters. After both reverted, libdns + admincli code restored from git history; system back to pre-Phase-3 state via the old plugin cliCommand surface.
Runtime validation
Post-merge, when workflow-plugin-infra v1.0.0 is published + the workflow-registry pin-bumped, verify:
--zone ` works through the new builtin
Part of cross-repo cascade
`docs/plans/2026-05-26-dns-provider-contract.md` (this repo). PR 8 of 9. After merge + v1.0.0 tag, the workflow-registry pin-bump PR is the final step of Phase 3.
Test plan
🤖 Generated with Claude Code