fix: scenario 51 deployment — use writable data dir#4
Merged
Conversation
Distroless nonroot container can't mkdir /var/lib/workflow. Use the writable /data emptyDir for iac-state. Remove PVC since mock test scenario doesn't need persistent state. Verified: 13/13 tests passing on minikube. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates scenario 51’s Kubernetes deployment and workflow config to use a writable, in-container data directory for IaC filesystem state, avoiding permission issues when running as a non-root/distroless container.
Changes:
- Move IaC filesystem state directory from
/var/lib/workflow/iac-stateto/data/iac-state. - Remove the dedicated IaC-state PVC and its corresponding volume mount from the scenario’s K8s manifest.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scenarios/51-bmw-iac/k8s/app.yaml | Removes the IaC-state PVC + mount, relying on the existing /data volume instead. |
| scenarios/51-bmw-iac/config/app.yaml | Points the iac.state filesystem backend directory to /data/iac-state. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/data/iac-stateinstead of/var/lib/workflow/iac-statefor IaC state dirTest plan
🤖 Generated with Claude Code