Fix 3 UI bugs found during exploratory testing#21
Merged
Conversation
- Fix node handle mapping: http.router/handler/proxy were mapped to
HTTPServerNode (no input handle), preventing incoming connections.
Now only http.server maps to httpNode; other http.* types map to
httpRouterNode which has both input and output handles.
- Fix dynamic component API field mismatch: createDynamicComponent
sent {name} but Go server expects {id}. Changed to {id: name}.
- Fix missing undo history for property edits: updateNodeConfig and
updateNodeName now call pushHistory() before mutating state, so
property changes can be undone with Ctrl+Z.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
intel352
added a commit
that referenced
this pull request
Feb 17, 2026
- Validate plugin name against directory traversal in CompositeRegistry.Install() - Add isSafePathComponent() to validate plugin name/version in HTTP handler - Validate planID in FileStateStore.GetPlan() to prevent path traversal Fixes code scanning alerts #20, #21, #22. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced May 31, 2026
intel352
added a commit
that referenced
this pull request
Jun 1, 2026
* ci(iac/admin): fail on stale vendored infra.proto descriptor Adds scripts/check-vendored-proto.sh and .github/workflows/proto-vendor-staleness.yml to catch upstream drift in iac/admin/testdata/infra.proto. How the script works: 1. Reads '// Source version: <tag>' from the vendored file header 2. Fetches the upstream proto from GoCodeAlone/workflow-plugin-infra@<tag> via the GitHub raw API (no local checkout required) 3. Extracts the *Config message name sets from both files 4. Diffs them; exit 1 + operator-readable error if any message was added or removed (with 'make vendor-infra-proto' refresh instructions) Verified locally: bash scripts/check-vendored-proto.sh → exit 0 (in-sync) (mutate proto) && bash ... → exit 1 (drift detected) actionlint proto-vendor-staleness.yml → exit 0 (no YAML issues) The CI job runs on push/PR to main when the proto or script changes, plus a weekly cron to catch upstream drift even when the local file is not touched. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * docs(scripts): annotate extract_config_messages scope matches catalog parity test Per spec-reviewer cosmetic suggestion: explain that *Config message scope is intentional — matches catalog_proto_parity_test.go surface. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(scripts): use sed -E (ERE) for BSD/macOS portability in extract_config_messages \+ is a GNU BRE extension unsupported by BSD sed; -E with + works on both macOS and Linux. CI (ubuntu-latest) was correct either way; this fixes local dev experience on macOS. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
http.router,http.handler,http.proxy,api.handler, andchimux.routerwere all mapped toHTTPServerNode(which hashasInput={false}), making them unable to receive incoming connections. Now onlyhttp.servermaps tohttpNode; all other HTTP types map tohttpRouterNodewith both input and output handles.createDynamicComponentinapi.tssent{ name, source, language }but the Go server atdynamic/api.goexpects{ id, source }. Changed to{ id: name, source, language }.updateNodeConfig()andupdateNodeName()now callpushHistory()before mutating state, so property changes via the PropertyPanel can be undone with Ctrl+Z.Test plan
🤖 Generated with Claude Code