-
Notifications
You must be signed in to change notification settings - Fork 0
auth.m2m: Support configurable route path suffixes for OAuth2 endpoints #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
intel352
merged 4 commits into
main
from
copilot/support-configurable-route-path-suffixes
Mar 12, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d90207f
Initial plan
Copilot e850345
auth.m2m: add configurable OAuth2 endpoint path suffixes via SetEndpo…
Copilot 4096dbb
Merge branch 'main' into copilot/support-configurable-route-path-suff…
intel352 b197df5
auth.m2m: validate endpoint paths, fix data race, clarify schema desc…
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SetEndpointsaccepts arbitrary strings which are later used withstrings.HasSuffixfor routing, but there’s no validation to catch common misconfigurations (e.g., missing leading '/', duplicate paths between Token/Revoke/Introspect/JWKS, or values that are too generic like "/token" causing unintended matches). Consider validating the resulting endpoint paths (non-empty, distinct, and maybe must start with '/') and surfacing a clear init error when invalid so the module doesn’t start with unreachable/ambiguous endpoints.