fix(plugin): keep active plugin on reload failure#680
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors ExternalPluginManager.ReloadPlugin so the replacement plugin subprocess is started and validated before the previously active client is killed. On candidate failure the old plugin remains registered, addressing the try-activate/rollback requirement from issue #667. Documentation and a comment are updated to reflect the new local-activation semantics.
Changes:
- Extract subprocess startup into
startPluginLockedreturning apluginLaunch, injectable via astartPlugintest seam. - Rewrite
ReloadPluginto load+validate the candidate first, only killing the old client on success, and to load directly when no plugin is currently active. - Update
handleReloadcomment anddocs/PLUGIN_DEVELOPMENT_GUIDE.mdto document try-activate semantics and clarify that artifact trust is out of scope.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| plugin/external/manager.go | Splits start logic out of LoadPlugin and reimplements ReloadPlugin to swap clients only after successful candidate launch. |
| plugin/external/manager_test.go | Adds tests covering reload failure preserving the active client and reload success swapping clients only after candidate start. |
| plugin/external/handler.go | Updates the handleReload doc comment to reflect new behavior. |
| docs/PLUGIN_DEVELOPMENT_GUIDE.md | Documents try-activate reload semantics and explicit non-goals (trust/fleet rollout). |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
Reject nil reload adapters and expand manager reload/load tests for PR #680 patch coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Regression Proof
With adapter validation absent:
failed because nil-adapter launches were accepted and registered.
With the validation restored:
passes.
Addresses the external plugin process handoff slice of #667. The broader config-engine probe/rollback contract remains tracked by #667.