fix(plugin): sanitize remote step payloads#708
Merged
Conversation
Remote steps must not send host-only HTTP metadata or engine internal config keys through strict protobuf plugin contracts.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens external (gRPC) step execution by sanitizing payloads that are encoded into protobuf Struct/typed Any, preventing failures/leakage when pipeline metadata or engine-internal config keys are present.
Changes:
- Filter pipeline metadata entries that cannot be represented by
google.protobuf.Structbefore sending them to remote steps. - Strip engine-internal
_-prefixed config keys (e.g._config_dir) before STRICT_PROTO typed config encoding. - Add regression tests covering HTTP metadata filtering and
_config_dirstripping for strict contracts.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| plugin/external/remote_step.go | Filters unrepresentable metadata prior to Struct encoding; strips internal config keys prior to typed config encoding. |
| plugin/external/remote_step_test.go | Adds regression coverage ensuring invalid HTTP metadata doesn’t break remote calls and strict typed config encoding ignores _config_dir. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependency
Verification