fix(wfctl): match GitHub secrets case-insensitively#751
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates wfctl infra bootstrap secret existence detection to correctly treat GitHub Actions secret names as case-insensitive when using write-only providers (where Get() is unsupported and List() is used), preventing unnecessary regeneration of provider credentials.
Changes:
- Added a GitHub-specific case-insensitive match (
strings.EqualFold) when checkingList()results for existing secret keys. - Extended the write-only secrets provider test double to allow configuring
Name()(so GitHub-specific behavior can be exercised). - Added a regression test ensuring uppercase GitHub-listed subkeys (e.g.,
SPACES_ACCESS_KEY) satisfy mixed-case generated probes (e.g.,SPACES_access_key).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmd/wfctl/infra_bootstrap.go | Adds GitHub-specific case-insensitive matching when using List() for existence checks. |
| cmd/wfctl/infra_bootstrap_secrets_test.go | Adds regression coverage for GitHub uppercase secret listings and updates the test provider to support configurable Name(). |
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
intel352
force-pushed
the
fix/github-secret-case-insensitive
branch
from
f26b6d6 to
d2c7461
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- treat GitHub Actions secret names as case-insensitive when wfctl auto-bootstrap checks write-only List() results\n- add regression coverage for generated DO Spaces provider credentials listed as SPACES_ACCESS_KEY / SPACES_SECRET_KEY\n\n## Verification\n- GOWORK=off go test ./cmd/wfctl -run 'TestBootstrapSecrets_(WriteOnlyProviderSkipsExisting|GitHubProviderCredentialMatchesUppercaseList|ProviderCredentialAllSubKeysPresent|ProviderCredentialPartialRegenerates)'\n- GOWORK=off go test ./cmd/wfctl ./secrets