feat(interfaces): IsErrResourceNotFound helper + struct Is method + 11 call-site migrations#788
Merged
intel352 merged 3 commits intoMay 27, 2026
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
intel352
added a commit
that referenced
this pull request
May 27, 2026
…retrospective (#789) PR #788 merged 2026-05-27. 3 design cycles + 2 plan cycles. All findings prescient or resolved upfront. Skipped brainstorming was the one process miss; identified as Plugin-level follow-up addressable via self-challenge prompt update. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugs gRPC-boundary gap where
errors.Is(err, ErrResourceNotFound)fails on cross-wire stringified errors. FollowsErrImageNotInRegistryload-bearing-string precedent. No SDK changes.Changes
platform.ResourceNotFoundError.Is(target)— makeserrors.Is(err, interfaces.ErrResourceNotFound)catch the struct nativelyinterfaces.IsErrResourceNotFound(err)— helper covering sentinel + struct + gRPC-stringified (viastrings.Containsfallback on the load-bearing message string)ErrResourceNotFoundmessage stringCall sites migrated
cmd/wfctl/infra_apply.go:isIaCNotFoundbody collapsed to delegation (1) + delete-error paths (2)cmd/wfctl/deploy_providers.go: read + update error paths during deploy (2)platform/differ.go:classifyCreatecascade-retro gap (1)iac/refreshoutputs/refresh.go: refresh-outputs not-found (1)module/tenant_resolver.go: tenant lookup by slug + domain (2)module/tenants.go: tenant fetch + update (2)Note:
deploy_providers.go:389is afmt.Errorf("%w: ...")WRAPPING site — not migrated per plan.Design
docs/plans/2026-05-27-iac-not-found-sentinel-translation-design.mdTest plan
GOWORK=off go test ./platform/...—TestResourceNotFoundError_IsErrResourceNotFoundgreenGOWORK=off go test ./interfaces/...—TestErrResourceNotFound_MessageStringStable+TestIsErrResourceNotFound(6 cases) greenGOWORK=off go test ./...— all packages greenGOWORK=off golangci-lint run --new-from-rev=origin/main— 0 issues🤖 Generated with Claude Code