feat(cigen): config-derived Jenkins + CircleCI renderers + wfctl four-platform support (#804)#810
Merged
Merged
Conversation
…ch + I4/I5 test rewrite + m4)
…hase test (PR1 review)
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
This was referenced May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR 1 of 3 for #804. Adds config-derived
cigen.RenderJenkins+cigen.RenderCircleCI(mechanical emitters from the existingCIPlan, mirroring the GHA renderer's plan/apply/smoke job set) and wires all four platforms intowfctl ci generate. NoAnalyzechange, no new CIPlan field, no GHA/GitLab output change.Refs #804 (acceptance #1:
wfctl ci generate --platform jenkins|circleciconfig-derived). PR2 rewires the ci-generator plugin (acceptance #2); PR3 adds the workflow-scenarios proof.Design / Plan / ADR
docs/plans/2026-05-31-cigen-jenkins-circleci-design.md(adversarial design review PASS at cycle 3)docs/plans/2026-05-31-cigen-jenkins-circleci.md(plan-phase PASS cycle 2; alignment PASS; scope locked)Changes
cigen/render_jenkins.go— declarative Jenkinsfile: single linearstages{}; per-phase plan stages gatedwhen { changeRequest() }; per-phase apply stages gatedwhen { branch 'main' }with per-stageenvironment { NAME = credentials('NAME') }(scoped viaphase.Scoped), plan-guard, last-phase migrations (wfctl migrations up), smoke. Header comment surfaces the Multibranch Pipeline requirement + the sorted required-credentials union.cigen/render_circleci.go— CircleCI 2.1: per-phaseplan/applyjobs + aworkflows:graph (requires:chain, branch filters); auto-injected project env vars (no redundant re-declare); plan-guard; last-phase migrations; smoke.cmd/wfctl/ci.go+ci_wizard.go—jenkins/circlecicases in both render switches; all usage/flag text + both error strings list four platforms; wizardplatformOptionsextended.docs/WFCTL.md— four-platformci generatereference + examples.Verification
go test ./cigen/— PASS (Jenkins + CircleCI: config-derived markers, valid YAML/structure, scoped-phase binding, nil-plan, single-phase, absence of legacygo test/wfctl deploy --image/docker buildper ADR 0044).go test ./cmd/wfctl/— PASS (four-platform switch dispatch).golangci-lint run --new-from-rev=origin/main ./cigen/... ./cmd/wfctl/...— 0 issues.wfctlbuilt from this branch):Post-merge
Tag v0.68.0 (the prerequisite for PR2's
go.modbump). Version is ldflag-injected at release.Note
Copilot review intentionally not requested (Copilot review broken). Merge gate = adversarial-review clean + two-stage code review APPROVED + CI green.
🤖 Generated with Claude Code