Feat/footer #27
Merged
Feat/footer #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Component for Twitter icon
MUI の Link の見た目に Next.js の Link の動作を組み合わせて利用するためのコンポーネントを用意した See also: https://omkz.net/nextjs-mu-link/
snaka
commented
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backlog
実装
Link: MUI の LInk の見た目に Next.js の Link の機能を組み合わせたコンポーネントを作成したIconTwitter: Twitter アイコンを MUI の SvgIcon を利用して表示するだけのコンポーネントFooter:Code of Conductなど ) を埋め込んだ動作確認
(PC)
(モバイル)
気になる点
width,heightの値を変更しないとアイコンの右側が切れて表示されていたので現在のような値 (width: '32px', height: '24px') を設定している。SVG の扱いかたがよくわかっていないので、ちゃんとした方法があるのかもしれない ...