-
Notifications
You must be signed in to change notification settings - Fork 42
Zone definition split #398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…dding some new biome types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR extracts the inline zoneconfig block from each room definition and places it into a dedicated zone-config.yaml in the room’s folder, while stripping out the old inline sections.
- Added
zone-config.yamlfiles per room containing metadata (name, roomid, and optional settings). - Removed
zoneconfig:sections from each room’s main YAML file. - Standardized the loader to read pattern-based YAML files (JSON support removed).
Reviewed Changes
Copilot reviewed 50 out of 50 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| _datafiles/world/default/rooms/shadow_realm/zone-config.yaml | New zone metadata file |
| _datafiles/world/default/rooms/shadow_realm/75.yaml | Removed inline zoneconfig |
| _datafiles/world/default/rooms/nowhere/zone-config.yaml | New zone metadata file |
| _datafiles/world/default/rooms/nowhere/-1.yaml | Removed inline zoneconfig |
| _datafiles/world/default/rooms/mystarion/zone-config.yaml | New zone metadata file |
| _datafiles/world/default/rooms/mystarion/612.yaml | Removed inline zoneconfig |
| _datafiles/world/default/rooms/mirror_caves/zone-config.yaml | New zone metadata file |
| _datafiles/world/default/rooms/mirror_caves/218.yaml | Removed inline zoneconfig |
| _datafiles/world/default/rooms/frostfang_slums/zone-config.yaml | New zone metadata file |
| _datafiles/world/default/rooms/frostfang_slums/439.yaml | Removed inline zoneconfig |
| _datafiles/world/default/rooms/frostfang/zone-config.yaml | New zone metadata file |
| _datafiles/world/default/rooms/frostfang/1.yaml | Removed inline zoneconfig |
| _datafiles/world/default/rooms/frost_lake/zone-config.yaml | New zone metadata file |
| _datafiles/world/default/rooms/frost_lake/304.yaml | Removed inline zoneconfig |
| _datafiles/world/default/rooms/endless_trashheap/zone-config.yaml | New zone metadata file |
| _datafiles/world/default/rooms/endless_trashheap/139.yaml | Removed inline zoneconfig |
| _datafiles/world/default/rooms/dark_forest/zone-config.yaml | New zone metadata file |
| _datafiles/world/default/rooms/dark_forest/300.yaml | Removed inline zoneconfig |
| _datafiles/world/default/rooms/catacombs/zone-config.yaml | New zone metadata file |
| _datafiles/world/default/rooms/catacombs/32.yaml | Removed inline zoneconfig |
Comments suppressed due to low confidence (3)
_datafiles/world/default/rooms/frostfang_slums/zone-config.yaml:7
- The list item under
mutatorsis not indented under the key, which will produce invalid YAML. Indent the dash by two spaces (e.g., ' - mutatorid: pvp-enabled').
- mutatorid: pvp-enabled
_datafiles/world/default/rooms/frostfang/zone-config.yaml:7
- The list item under
idlemessagesis not indented under the key, causing invalid nesting. Add two spaces before the dash (e.g., ' - A cold wind blows through the city.').
- A cold wind blows through the city.
_datafiles/world/default/rooms/dark_forest/zone-config.yaml:4
- This sequence item under
mutatorsis not indented, which will break YAML parsing. Prefix the dash with two spaces to nest it correctly.
- mutatorid: forest-mist
Description
This splits zone configuration outside of the root room definition file.
Changes
zone-config.yamlin the room/zone folder.zone-config.yaml