Skip to content

Conversation

@Volte6
Copy link
Member

@Volte6 Volte6 commented Jun 3, 2025

Description

This splits zone configuration outside of the root room definition file.

Changes

  • zone config is from a file called zone-config.yaml in the room/zone folder.
  • Changed fileloader Load/Save functions, allows for file patterns to match when loading.
  • Eliminated JSON as a fileformat. Wasn't really supported anyways.
  • Room ZoneConfig now a pointer, expected to be null
    • If not null, uses data to generate a new zone-config.yaml

@Jasrags Jasrags requested a review from Copilot June 16, 2025 18:47
@Jasrags Jasrags added the enhancement New feature or request label Jun 16, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extracts the inline zoneconfig block from each room definition and places it into a dedicated zone-config.yaml in the room’s folder, while stripping out the old inline sections.

  • Added zone-config.yaml files per room containing metadata (name, roomid, and optional settings).
  • Removed zoneconfig: sections from each room’s main YAML file.
  • Standardized the loader to read pattern-based YAML files (JSON support removed).

Reviewed Changes

Copilot reviewed 50 out of 50 changed files in this pull request and generated no comments.

Show a summary per file
File Description
_datafiles/world/default/rooms/shadow_realm/zone-config.yaml New zone metadata file
_datafiles/world/default/rooms/shadow_realm/75.yaml Removed inline zoneconfig
_datafiles/world/default/rooms/nowhere/zone-config.yaml New zone metadata file
_datafiles/world/default/rooms/nowhere/-1.yaml Removed inline zoneconfig
_datafiles/world/default/rooms/mystarion/zone-config.yaml New zone metadata file
_datafiles/world/default/rooms/mystarion/612.yaml Removed inline zoneconfig
_datafiles/world/default/rooms/mirror_caves/zone-config.yaml New zone metadata file
_datafiles/world/default/rooms/mirror_caves/218.yaml Removed inline zoneconfig
_datafiles/world/default/rooms/frostfang_slums/zone-config.yaml New zone metadata file
_datafiles/world/default/rooms/frostfang_slums/439.yaml Removed inline zoneconfig
_datafiles/world/default/rooms/frostfang/zone-config.yaml New zone metadata file
_datafiles/world/default/rooms/frostfang/1.yaml Removed inline zoneconfig
_datafiles/world/default/rooms/frost_lake/zone-config.yaml New zone metadata file
_datafiles/world/default/rooms/frost_lake/304.yaml Removed inline zoneconfig
_datafiles/world/default/rooms/endless_trashheap/zone-config.yaml New zone metadata file
_datafiles/world/default/rooms/endless_trashheap/139.yaml Removed inline zoneconfig
_datafiles/world/default/rooms/dark_forest/zone-config.yaml New zone metadata file
_datafiles/world/default/rooms/dark_forest/300.yaml Removed inline zoneconfig
_datafiles/world/default/rooms/catacombs/zone-config.yaml New zone metadata file
_datafiles/world/default/rooms/catacombs/32.yaml Removed inline zoneconfig
Comments suppressed due to low confidence (3)

_datafiles/world/default/rooms/frostfang_slums/zone-config.yaml:7

  • The list item under mutators is not indented under the key, which will produce invalid YAML. Indent the dash by two spaces (e.g., ' - mutatorid: pvp-enabled').
- mutatorid: pvp-enabled

_datafiles/world/default/rooms/frostfang/zone-config.yaml:7

  • The list item under idlemessages is not indented under the key, causing invalid nesting. Add two spaces before the dash (e.g., ' - A cold wind blows through the city.').
- A cold wind blows through the city.

_datafiles/world/default/rooms/dark_forest/zone-config.yaml:4

  • This sequence item under mutators is not indented, which will break YAML parsing. Prefix the dash with two spaces to nest it correctly.
- mutatorid: forest-mist

@Volte6 Volte6 merged commit 44284cf into master Jun 19, 2025
6 checks passed
@Volte6 Volte6 deleted the zone-definition-split branch June 19, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants