Use comma-ok type assertion for UserObject in connection handlers#461
Merged
Volte6 merged 1 commit intoGoMudEngine:masterfrom Apr 6, 2026
Merged
Conversation
Direct type assertion uo.(*users.UserRecord) on any value from map[string]any will panic if the value is an unexpected type. Use comma-ok form and handle failure gracefully by logging, removing the connection, and breaking the read loop. Applied to both handleTelnetConnection and HandleWebSocketConnection. Fixes #7 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Volte6
approved these changes
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces direct type assertions with comma-ok form in both telnet and WebSocket connection handlers to prevent panics.
Changes
Both handleTelnetConnection and HandleWebSocketConnection used a direct type assertion on a value from map[string]any, which will panic if the value is an unexpected type. Changed to comma-ok form with graceful error handling (log error, disconnect, break).
Test plan