Add internal authorization check to system commands#463
Merged
Volte6 merged 2 commits intoGoMudEngine:masterfrom Apr 6, 2026
Merged
Add internal authorization check to system commands#463Volte6 merged 2 commits intoGoMudEngine:masterfrom
Volte6 merged 2 commits intoGoMudEngine:masterfrom
Conversation
trySystemCommand() now verifies the user has admin role before executing /shutdown or /reload. Previously authorization was only enforced at handler registration time in main.go, with no check inside the command handler itself. /quit remains available to all users. Adds 8 test cases covering admin/non-admin/unknown connection scenarios. Adds SetTestConnection helper for cross-package tests. Fixes #4 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Volte6
approved these changes
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds defense-in-depth authorization check inside trySystemCommand for /shutdown and /reload. Previously authorization was only enforced at handler registration time in main.go — if registration was ever bypassed, any connection could trigger server shutdown or data reload.
Changes
Tests
8 test cases covering: shutdown/reload rejected for non-admin user, rejected for unknown connection, accepted for admin, unknown command and non-slash prefix handled correctly.