Fix: CI Javascript Lint Test#480
Merged
Volte6 merged 6 commits intoGoMudEngine:masterfrom Apr 16, 2026
Merged
Conversation
Volte6
requested changes
Apr 16, 2026
Member
Volte6
left a comment
There was a problem hiding this comment.
JS linting should also check scripts defined in the _datafiles folder and nested folders. That's actually the primary purpose of the js linting - to make sure the scripts won't break when they are dynamically loaded/executed.
Collaborator
Author
|
Updated |
Volte6
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
make js-lint.Why
Changes
.github/workflows/lint.ymlto runmake js-lintand use Node 22.make js-lintin theMakefileto the maintained webclient and admin JavaScript paths.Makefilefromnode:20tonode:22..jshintrcfor the browser-oriented frontend code and suppress the warnings used by these maintained scripts./* global */declarations in the affected frontend files, includingwindow-gametime.jsandwindow-map.js, so the lint step passes without changing runtime behavior.Validation
make js-lint