Skip to content

[CI] Fix: Windows-specific build failure#488

Merged
CaseyLabs merged 3 commits intoGoMudEngine:masterfrom
clabs-public-forks:fix/windows-release-build
Apr 17, 2026
Merged

[CI] Fix: Windows-specific build failure#488
CaseyLabs merged 3 commits intoGoMudEngine:masterfrom
clabs-public-forks:fix/windows-release-build

Conversation

@CaseyLabs
Copy link
Copy Markdown
Collaborator

@CaseyLabs CaseyLabs commented Apr 17, 2026

Summary

  • fix the Windows release cross-build failure
  • keep the change scoped to cross-platform signal handling and the copyover reconnect-token hook

Root Cause

  • main.go referenced syscall.SIGTSTP unconditionally, which does not exist on Windows
  • connections.IssueWebSocketReconnectToken was only declared in the Unix-specific file, so Windows builds could not compile main.go

Changes

  • add OS-specific shutdown signal helpers for Unix and Windows
  • keep SIGTSTP on Unix only
  • declare the reconnect-token hook in the Windows connections file so the shared wiring in main.go compiles on both platforms

Validation

  • GOOS=windows GOARCH=amd64 go build -v -o /tmp/go-mud-windows_x64.exe .
  • go test ./internal/connections ./internal/copyover

Impact

  • release workflows can now complete the Windows build step
  • no intended behavior change for Unix runtime handling

@CaseyLabs CaseyLabs force-pushed the fix/windows-release-build branch from a9d981a to c90e26b Compare April 17, 2026 13:56
@CaseyLabs CaseyLabs marked this pull request as ready for review April 17, 2026 13:59
@CaseyLabs CaseyLabs requested a review from Volte6 as a code owner April 17, 2026 13:59
@CaseyLabs CaseyLabs changed the title Fix: Windows-specific build failure Fix: [CI] Windows-specific build failure Apr 17, 2026
@CaseyLabs CaseyLabs changed the title Fix: [CI] Windows-specific build failure [CI] Fix: Windows-specific build failure Apr 17, 2026
Copy link
Copy Markdown
Member

@Volte6 Volte6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change. What do you think about consolidating these signals changes with those found in copyover_signal_unix.go and copyover_signal_windows.go?

Maybe signals_unix.go and signals_windows.go? That way we don't incrementally add more and more files everytime we have new signals we want to add.

@CaseyLabs
Copy link
Copy Markdown
Collaborator Author

@Volte6 - made the following change in commit 151bf94 ... is this what you had in mind? No worries if I misunderstood.

Consolidated the OS-specific signal handling into signals_unix.go and signals_windows.go, moving the shutdown and copyover signal helpers into those two platform files without changing behavior. This keeps the Windows fix intact while avoiding additional one-off signal files.

@CaseyLabs CaseyLabs merged commit ae703f1 into GoMudEngine:master Apr 17, 2026
3 checks passed
@CaseyLabs CaseyLabs deleted the fix/windows-release-build branch April 17, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants