[CI] Fix: Windows-specific build failure#488
Merged
CaseyLabs merged 3 commits intoGoMudEngine:masterfrom Apr 17, 2026
Merged
Conversation
a9d981a to
c90e26b
Compare
This was referenced Apr 17, 2026
Volte6
reviewed
Apr 17, 2026
Member
Volte6
left a comment
There was a problem hiding this comment.
Good change. What do you think about consolidating these signals changes with those found in copyover_signal_unix.go and copyover_signal_windows.go?
Maybe signals_unix.go and signals_windows.go? That way we don't incrementally add more and more files everytime we have new signals we want to add.
Collaborator
Author
|
@Volte6 - made the following change in commit 151bf94 ... is this what you had in mind? No worries if I misunderstood. Consolidated the OS-specific signal handling into |
Volte6
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
main.goreferencedsyscall.SIGTSTPunconditionally, which does not exist on Windowsconnections.IssueWebSocketReconnectTokenwas only declared in the Unix-specific file, so Windows builds could not compilemain.goChanges
SIGTSTPon Unix onlymain.gocompiles on both platformsValidation
GOOS=windows GOARCH=amd64 go build -v -o /tmp/go-mud-windows_x64.exe .go test ./internal/connections ./internal/copyoverImpact