Merged
Conversation
CaseyLabs
commented
Apr 20, 2026
| const icon = document.createElement('span'); | ||
| icon.className = 'rw-icon locked'; | ||
| icon.textContent = '\u{1f512}'; | ||
| icon.textContent = '\ud83d\udd12'; |
Collaborator
Author
There was a problem hiding this comment.
\ud83d\udd12 is valid JavaScript, renders the same lock (🔒) character, and is safer under the current JSHint setup than \u{1f512}, which was the form that triggered the lint complaint.
Volte6
approved these changes
Apr 20, 2026
CaseyLabs
commented
Apr 20, 2026
| @@ -1,4 +1,4 @@ | |||
| /* global MP3Player, Triggers, WinBox */ | |||
| /* global Triggers */ | |||
Collaborator
Author
There was a problem hiding this comment.
MP3Player and WinBox now come from the shared JSHint config, so they do not need per-file headers anymore. Keeping a single inline /* global Triggers */ here is the simpler tradeoff because Triggers is the one remaining file-specific exception, and this avoids adding another dedicated JSHint config layer just for webclient-core.js.
CaseyLabs
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
/* global ... */headers in the webclient window modules were lint-only noiseLintworkflow mixed Go validation and JavaScript lint into one jobnpx jshintleft CI behavior vulnerable to tool driftChanges
make js-lint.jshintrc.webclient-windows.github/workflows/lint.ymlintogo-lintandjs-lintjs-lintwhen JS lint inputs changeValidation
make js-lintactionlint .github/workflows/lint.ymlyamllint .github/workflows/lint.yml