Add Hermes hook support#69
Merged
Merged
Conversation
AgentGuard PR ReviewThe Hermes hook support introduces a few concrete regressions and security gaps.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Hermes Agent runtime hook support for AgentGuard.
This PR introduces a Hermes shell-hook integration that maps Hermes
pre_tool_call/post_tool_callpayloads into AgentGuard’s existing runtime action evaluation engine.Changes
HermesAdapterfor Hermes tool payloads.skills/agentguard/scripts/hermes-hook.jsfor Hermes shell-hook execution.skills/agentguard/hermes-hooks.yamltemplate.docs/hermes.md, README, andskills/agentguard/SKILL.md.~/.hermes/skills.Notes
Hermes
pre_tool_callsupports allow/block only, so AgentGuardaskdecisions are represented as blocks with a confirmation-oriented message.SkillHub users must still copy/merge the hook template into
~/.hermes/config.yaml; Hermes does not auto-load hooks fromSKILL.md.Type
Testing
npm run buildpassesnpm testpasses (32 tests)Related Issues