Changes i told u about in skype#13
Conversation
GodDragoner
left a comment
GodDragoner
left a comment
There was a problem hiding this comment.
Everything else looks fine 👍
|
|
||
| inputBuffer.append(strLine); | ||
| inputBuffer.append('\n'); | ||
| if (!strLine.equals(image.getName())) { |
There was a problem hiding this comment.
Why would you check that first? In the case of !added the file was not tagged previously which means we need to add it no matter whether the tags are empty right?
Because otherwise it will be an untagged and completely unknown image right?
You could also just check for "if(!added && !tagsToAdd.isEmpty())".
There was a problem hiding this comment.
This is because, if the strLine is just the name of the image, then it doesn't have a dress state or any tags and we don't want a picture in the tags file if it doesn't have any tags or a dress state.
There was a problem hiding this comment.
Why wouldn't we want an image without any tags inside the tags file? Does it matter?
|
|
||
| lines.set(lines.indexOf(replaceLine), newLine); | ||
| TeaseLogger.getLogger().log(Level.INFO, "Added = " + added); | ||
| if (added) { |
There was a problem hiding this comment.
You can change this into an else statement with the already existing !added statement
There was a problem hiding this comment.
yea. Thats fine and remove that logger message. That was just for testing.
|
should be ready for review and merge |
|
Should be ready to merge this pull and push changes to release |
Changes to your commit to improve performance and removed unnecessary code
Changes i told u about in skype
Merge pull request #13 from skier233/master
2 participants
ddd