refactor: ♻️ Added compatible_mod_loader_version to manifest data #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ray_from_dict()`
Added `compatible_mod_loader_version` to manifest data. This field has been changed from a single String to a PoolStringArray for parity with other version fields. Added handling for this change and deprecation warning. Single String value for `compatible_mod_loader_version` deprecated
KANAjetzt
force-pushed
the
manifest_compatible_mod_loader_version
branch
from
b4a5f16 to
01f0ca5
Compare
ithinkandicode
approved these changes
Mar 2, 2023
Collaborator
ithinkandicode
left a comment
ithinkandicode
left a comment
There was a problem hiding this comment.
Minor bits, overall looks great 👍
KANAjetzt
changed the title
Reworked comments to fit the latest discussion in GodotModding#166
Added `compatible_mod_loader_version` to `get_as_dict()`
version number validation for array values of `compatible_mod_loader_version` in `_handle_compatible_mod_loader_version()`
Reworked strings to fit the latest discussion in GodotModding#166
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
compatible_mod_loader_versionto manifest data. This field has been changed from a singleStringto aPoolStringArrayfor parity with other version fields. Added handling for this change and deprecation warning.compatible_mod_loader_versiondeprecated