refactor: ♻️ split off dep and inc validation function #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
splited `validate_dependencies_and_incompatibilities()` in to `validate_dependencies()`, `validate_incompatibilities()` and `is_mod_id_array_valid()`. Will be used in the ModTool to validate the fields separately.
Qubus0
approved these changes
Mar 5, 2023
Collaborator
Qubus0
left a comment
Qubus0
left a comment
There was a problem hiding this comment.
Small things, overall merge ready
Added *mod_id_array_description* to log_fatal() in `is_mod_id_array_valid()`
Removed the `break` in the mod id check, so all invalid values get logged at once and the user doesn't have to fix one error to get the next one.
KANAjetzt
force-pushed
the
split_validate_dependencies_and_incompatibilities
branch
from
3423dd8 to
134e7d8
Compare
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
splited
validate_dependencies_and_incompatibilities()in tovalidate_dependencies(),validate_incompatibilities()andis_mod_id_array_valid(). Will be used in the ModTool to validate the fields separately.