-
Notifications
You must be signed in to change notification settings - Fork 44
fix: ♻️ ModID in dependencies and incompatibilities
#174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Qubus0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good so far, pls test
Changed the function name `has_overlaps()` -> `validate_dependencies_and_incompatibilities_conflicts()` | Changed the log text to include the mod id | Calling the function in `_init()` instead of `validate_dependencies_and_incompatibilities()`
dependencies and incompatibilities
dependencies and incompatibilitiesdependencies and incompatibilities
Qubus0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, thanks. not sure if we need it but technically, an incompatibility should also not be an optional dependency. might not be in the scope here since the optional ones were added after this issue
dependencies and incompatibilitiesdependencies and incompatibilities

Adds validation function
validate_dependencies_and_incompatibilities_conflicts()to mod_manifest.gdValidates a mod's
dependenciesandincompatibilitiesto ensure they don't conflict.closes #169