test: ✅ tests for manifest validation #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qubus0
approved these changes
Apr 17, 2023
Collaborator
Qubus0
left a comment
Qubus0
left a comment
There was a problem hiding this comment.
looks good for now, though i'd like to use the params = use_parameters(...) way, since that also creates a test case that can fail individually.
What I wold like to see is the .gitattributes file, so downloading via zip/asset lib won't contain all the tests
Member
Author
|
I will rework it to use the parameterized tests and add the |
KANAjetzt
force-pushed
the
gut_unit_tests
branch
from
fc4a13b to
dad5ef4
Compare
updated `test_validate_distinct_mod_ids_in_arrays()` and `test_is_mod_id_array_valid()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for:
is_mod_id_valid()by @Qubus0validate_distinct_mod_ids_in_arrays()test_is_mod_id_array_valid()