refactor: ♻️ Split up ModLoaderUtils
#226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and moved all file related utils there
Moved all relevant functions from *mod_loader_utils.gd* and updated the function calls.
and removed `get_autoload_index()` because it was only used by the self setup. That is using *setup_utils.gd* now.
moved all relevant functions from *mod_loader_utils.gd*, updated all function calls.
Qubus0
approved these changes
Apr 20, 2023
Collaborator
Qubus0
left a comment
Qubus0
left a comment
There was a problem hiding this comment.
internalize all the things!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits up
ModLoaderUtilsinto this new Classes:/internal dir
mod_loader_utils.gdto/internal/mod_loader_utils.gd/api/godot.gdto/internal/godot.gdfile.gdin/internalcli.gdin/internalpath.gdin/internalI also
_get_autoload_array()toModLoaderGodotand removedget_autoload_index()because it was only used by the self setup. - 4fdae39works towards #153