refactor: ♻️ Ignore hidden directories #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otDan
approved these changes
May 26, 2023
KANAjetzt
reviewed
May 26, 2023
addons/mod_loader/mod_loader.gd
Outdated
| continue | ||
|
|
||
| # Ignore hidden directories | ||
| if mod_dir_name.begins_with("."): |
Member
There was a problem hiding this comment.
While we're here, we can probably put these three together.
if (
not dir.current_is_dir() or
mod_dir_name.begins_with(".") or
mod_dir_name == ".."
):
continue
KANAjetzt
added
enhancement
KANAjetzt
changed the title
Contributor
Author
|
Ive pushed a change for combining the three statements as said above. Moved the comments to be alongside them and have the operators at the start of the lines for clarity + diff reasons |
if (
not dir.current_is_dir() or
mod_dir_name.begins_with(".") or
mod_dir_name == ".."
):
continueLogically it makes sense, but after combining conditions isn't this check redundant? |
Member
|
good point @aesereht |
Contributor
Author
|
Pushed another change to remove that last check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the mod loader will try to read hidden directories (such as .git) as if they were mods and then throw assertion errors. This just adds a small check to stop that