refactor: 🚚 move funcs out of ModLoader #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moved `load_mod_zips()` back to `ModLoader`
`Directory.new()` instead of `_ModLoaderFile`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved
_load_steam_workshop_zips()fromModLoaderto_ModLoaderSteam- rename toload_steam_workshop_zips()Moved_load_mod_zips()fromModLoaderto_ModLoaderFile- rename toload_mod_zips()Moved
_load_mod_zips()back toModLoaderbecause of cyclic dependencies._ModLoaderSteam.load_steam_workshop_zips()uses_ModLoaderFile.load_zips_in_folder(). This can be resolved with Generalize the _load_steam_workshop_zips() method #256Moved
_load_zips_in_folder(folder_path: String)fromModLoaderto_ModLoaderFilerename toload_zips_in_folder(folder_path: String)closes #153