Validate Globus Credentials#3
Open
TinasheMTapera wants to merge 7 commits into
Open
Conversation
for #1: feat(validate_globus): add globus credentials validation - Implemented a validation function for Globus credentials in the Sheriff class. - Utilized the Globus SDK to check user permissions for data access. - Created a GlobusClearance dataclass to encapsulate validation results. - Ensured proper error handling for API errors and invalid credentials.
* renamed validate_globus_credentials to issue_globus_transfer * updated function parameters to include issue_transfer flag * modified logic to handle transfer requests and validation more effectively * improved console output for better user feedback
* Change transfer_id type annotation for clarity * Remove unnecessary app attribute from GlobusClearance * Streamline globus_info retrieval in issue_globus_transfer
* Update check_globus_access to run transfer if credentials are valid * Enhance error handling by passing response to GlobusAPIError * Clarify docstrings for better understanding of functionality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for GoldenPlanetaryHealthLab/stagecoach#1:
feat(validate_globus): add globus credentials validation