fix(streaming-widget): finalize streaming widget with missing stories and tests (Refs #36)#37
Open
enok1111 wants to merge 2 commits into
Conversation
- Add WrongChain story for unsupported network prompt - Add LoadingState and ErrorState stories for Playwright routing - Add Playwright tests for wrong-chain, error state, pool connect/disconnect, and SUP reserve visibility on non-Base chains - Total tests increased from 8 to 12 covering all acceptance criteria
12 tasks
…ies and tests - Fix 6 pairs of duplicate lines in adapter.ts that broke the build - Add pool claim functionality via viem writeContract (GDA Pool claimAll) - Add claimableAmount to PoolMembershipItem and fetch via getClaimableNow - Add PoolClaim, BaseSupReserve, BaseSupBalance Storybook stories - Replace inline styles with Tamagui width prop in stories - Strengthen test assertions (waitForAllText, proper state verification) - Add 3 new tests: Base SUP reserve, Base SUP balance, pool claim actions - Remove unused http import and unused hash variable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finalize the streaming widget PR (#31) by fixing critical build errors, implementing missing pool claim functionality, adding required Storybook stories, and strengthening Playwright test coverage.
Changes
Critical Fixes
isWrongChain,viemClients,fetchStreams,fetchPools,fetchBalance,fetchSupReservedeclarations)httpimport and unusedhashvariableNew Feature: Pool Claim
claimableAmountfield toPoolMembershipItem— fetched viagetClaimableNowon each GDA Pool contractclaimFromPoolaction using viemwriteContractwith GDA Pool ABI (claimAllfunction)PoolCardUI to show claimable amount and Claim button for connected pools with claimable balancepoolClaimStatusandpoolClaimErrorstate tracking per poolNew Storybook Stories
PoolClaim— Custodial fixture showing pool memberships with claimable amounts and Claim actionBaseSupReserve— Mock provider on Base chain (8453) showing SUP Reserve sectionBaseSupBalance— Mock provider on Base chain showing Super Token balance for SUPTest Improvements
waitForAllTexthelper for stronger assertions requiring multiple text patternsStyle Fixes
style={{ width: 400 }}inline styles with Tamaguiwidth={400}prop in storiesAcceptance Criteria (from #36)
Streaming checks
WidgetTabsfor streams, pools, and balancesStorybook and test checks
Testing
Evidence
tests/widgets/streaming-widget/test-results/Linked Issues