Skip to content

fix(deployable): update remote service config on push for static envs#133

Merged
vigneshrajsb merged 1 commit into
mainfrom
fix/static-env-remote-service-push-update
Mar 16, 2026
Merged

fix(deployable): update remote service config on push for static envs#133
vigneshrajsb merged 1 commit into
mainfrom
fix/static-env-remote-service-push-update

Conversation

@vigneshrajsb
Copy link
Copy Markdown
Contributor

Summary

  • When a push to a service repo (e.g. consumer-mcp) triggers a rebuild of a static env (good-dev-0) via trackDefaultBranches, the previous guard in updateOrCreateDeployableUsingYamlConfig skipped all remote services when filterGithubRepositoryId was set — including the service that triggered the push
  • This left stale deployable config (e.g. helm.grpc:true) even after the source lifecycle.yaml was updated
  • Fix resolves filterGithubRepositoryId to a repo name once before the loop, then skips only remote services whose repo name does not match — so the triggering service is re-read and patched correctly

Root cause (PR #84 regression)

PR #84 changed importYamlConfigFile from being skipped entirely on push events to always running with a filter. The filter guard was written as if (filterGithubRepositoryId) return which skips every remote service, including the one that changed.

Test Plan

  • Push a commit to a service repo tracked by a static env with trackDefaultBranches=true — verify the deployable's helm config is updated
  • Confirm other remote services in the static env are still skipped (check debug logs: Skipping remote YAML fetch for filtered deploy)
  • Selective redeploy of a remote service in a static env updates its deployable config
  • PR env pushes unaffected (services are local to the PR repo, never hit the remote guard)

🤖 Generated with Claude Code

When a push event targets a static env (e.g. good-dev-0) with
trackDefaultBranches=true, the previous guard skipped ALL remote
services when filterGithubRepositoryId was set. This meant the
triggering repo's service config was never re-read from its
lifecycle.yaml, leaving stale values (e.g. grpc:true) in the
deployable after the source repo was updated.

Fix: resolve filterGithubRepositoryId to a repo name once upfront,
then skip only remote services whose repo name does NOT match.
The triggering service is now processed correctly while all other
remote deps are still skipped for performance.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@vigneshrajsb vigneshrajsb requested a review from a team as a code owner March 16, 2026 21:12
@vigneshrajsb vigneshrajsb merged commit 611299b into main Mar 16, 2026
5 checks passed
@vigneshrajsb vigneshrajsb deleted the fix/static-env-remote-service-push-update branch March 16, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants