fix(deployable): update remote service config on push for static envs#133
Merged
Merged
Conversation
When a push event targets a static env (e.g. good-dev-0) with trackDefaultBranches=true, the previous guard skipped ALL remote services when filterGithubRepositoryId was set. This meant the triggering repo's service config was never re-read from its lifecycle.yaml, leaving stale values (e.g. grpc:true) in the deployable after the source repo was updated. Fix: resolve filterGithubRepositoryId to a repo name once upfront, then skip only remote services whose repo name does NOT match. The triggering service is now processed correctly while all other remote deps are still skipped for performance. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
krishnavenkateswaran
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
consumer-mcp) triggers a rebuild of a static env (good-dev-0) viatrackDefaultBranches, the previous guard inupdateOrCreateDeployableUsingYamlConfigskipped all remote services whenfilterGithubRepositoryIdwas set — including the service that triggered the pushhelm.grpc:true) even after the sourcelifecycle.yamlwas updatedfilterGithubRepositoryIdto a repo name once before the loop, then skips only remote services whose repo name does not match — so the triggering service is re-read and patched correctlyRoot cause (PR #84 regression)
PR #84 changed
importYamlConfigFilefrom being skipped entirely on push events to always running with a filter. The filter guard was written asif (filterGithubRepositoryId) returnwhich skips every remote service, including the one that changed.Test Plan
trackDefaultBranches=true— verify the deployable'shelmconfig is updatedSkipping remote YAML fetch for filtered deploy)🤖 Generated with Claude Code