Skip to content

Generalize native Helm runner and post-renderer config#158

Merged
vigneshrajsb merged 2 commits into
mainfrom
fix/native-helm-post-renderer-v2
Apr 13, 2026
Merged

Generalize native Helm runner and post-renderer config#158
vigneshrajsb merged 2 commits into
mainfrom
fix/native-helm-post-renderer-v2

Conversation

@vigneshrajsb
Copy link
Copy Markdown
Contributor

What changed

  • add native Helm support for a configurable runner image
  • add generic post-renderer config with enabled, command, and args
  • merge native Helm config from global defaults, chart config, and service config with service overrides winning
  • validate merged native Helm config rather than only raw service config
  • add tests for default behavior, global config, overrides, disable semantics, and manifest generation from lifecycle YAML

Why

This lets native Helm deployments support custom runner images and Helm post-renderers without relying on CI-specific deploy steps.

Validation

  • pnpm exec jest src/server/lib/config/__tests__/ConfigBuilder.test.ts --runInBand
  • pnpm exec jest src/server/lib/nativeHelm/__tests__/helm.test.ts --runInBand
  • pnpm test

Comment thread src/server/lib/config/ConfigBuilder.ts Outdated
Comment on lines +20 to +24
export interface HelmPostRendererConfig {
enabled?: boolean;
command?: string;
args?: string[];
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate HelmPostRendererConfig interface

This interface is defined in three separate places with identical shapes:

These will drift over time. We should pick one canonical location (probably globalConfig.ts since it already defines NativeHelmConfig) and import it in the other two files.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call human! fixed

@vigneshrajsb vigneshrajsb marked this pull request as ready for review April 13, 2026 21:35
@vigneshrajsb vigneshrajsb requested a review from a team as a code owner April 13, 2026 21:35
@vigneshrajsb vigneshrajsb merged commit c54a601 into main Apr 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants