Skip to content

feat(helm): move native Helm wait logic into an init container#160

Merged
vigneshrajsb merged 1 commit into
mainfrom
fix/native-helm-wait-init-container
Apr 14, 2026
Merged

feat(helm): move native Helm wait logic into an init container#160
vigneshrajsb merged 1 commit into
mainfrom
fix/native-helm-wait-init-container

Conversation

@vigneshrajsb
Copy link
Copy Markdown
Contributor

Summary

  • move the native Helm prior-job wait loop out of the helm-deploy runner container
  • run that coordination step in a fixed kubectl init container before Helm executes
  • remove the apk/wget/jq assumptions from the custom Helm runner script
  • keep native Helm image and post-renderer support unchanged

Why

Custom native Helm runner images should only need to satisfy the Helm execution contract. The prior implementation also required image-specific tooling for Kubernetes API polling, which broke otherwise valid custom images.

This change narrows the runner contract while preserving existing deploy behavior:

  • clone-repo init container still handles repository checkout when needed
  • ecr-auth init container still handles OCI registry auth when needed
  • helm-deploy still performs repo/chart setup, registry login, and Helm execution
  • a new wait-for-prior-deploys init container handles serialized deploy coordination

Verification

  • pnpm exec jest src/server/lib/nativeHelm/__tests__/helm.test.ts --runInBand
  • pnpm exec jest src/server/lib/config/__tests__/ConfigBuilder.test.ts --runInBand

@vigneshrajsb vigneshrajsb force-pushed the fix/native-helm-wait-init-container branch from 4710ed2 to b9d640d Compare April 14, 2026 00:42
@vigneshrajsb vigneshrajsb marked this pull request as ready for review April 14, 2026 01:22
@vigneshrajsb vigneshrajsb requested a review from a team as a code owner April 14, 2026 01:22
@vigneshrajsb vigneshrajsb changed the title Move native Helm wait logic into an init container feat(helm): move native Helm wait logic into an init container Apr 14, 2026
@vigneshrajsb vigneshrajsb merged commit 11cd63c into main Apr 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants