feat(helm): move native Helm wait logic into an init container#160
Merged
Conversation
4710ed2 to
b9d640d
Compare
binlab
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
helm-deployrunner containerkubectlinit container before Helm executesapk/wget/jqassumptions from the custom Helm runner scriptWhy
Custom native Helm runner images should only need to satisfy the Helm execution contract. The prior implementation also required image-specific tooling for Kubernetes API polling, which broke otherwise valid custom images.
This change narrows the runner contract while preserving existing deploy behavior:
clone-repoinit container still handles repository checkout when neededecr-authinit container still handles OCI registry auth when neededhelm-deploystill performs repo/chart setup, registry login, and Helm executionwait-for-prior-deploysinit container handles serialized deploy coordinationVerification
pnpm exec jest src/server/lib/nativeHelm/__tests__/helm.test.ts --runInBandpnpm exec jest src/server/lib/config/__tests__/ConfigBuilder.test.ts --runInBand