fix(ttl): reconcile closed pull request namespaces#190
Merged
vigneshrajsb merged 1 commit intomainfrom Apr 28, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BuildService.deleteQueuefor closed/merged PR teardown so the TTL worker remains a scanner/reconciler and teardown stays in the existing delete path.Root cause
TTL cleanup previously only handled expired namespaces tied to open pull requests. If a close webhook or an in-flight deploy race left a closed-PR namespace behind, TTL would load the build and PR, see
pullRequest.status !== 'open', and skip it forever.Validation
pnpm test -- src/server/services/__tests__/ttlCleanup.test.tspassed.pnpm testpassed: 178 suites, 1605 tests.pnpm run lintpassed.pnpm exec prettier --check src/server/services/ttlCleanup.ts src/server/services/__tests__/ttlCleanup.test.tspassed.git diff --checkpassed.pnpm run ts-checkstill fails on existing repo-wide type errors outside this change, including stale.next/typesroute references, script strict-null errors, and unrelated service/model strictness issues. After fixing the optional comment fields inttlCleanup.ts, the rerun no longer reportsttlCleanup.tserrors.