use the secret name from the env var to be configurable#25
Merged
vigneshrajsb merged 2 commits intoGoodRxOSS:configurable-gh-secret-namefrom Jul 18, 2025
Merged
Conversation
vigneshrajsb
force-pushed
the
configurable-gh-secret-name
branch
from
3bc6385 to
b17ddcd
Compare
vigneshrajsb
merged commit 4bc2ce7
into
GoodRxOSS:configurable-gh-secret-name
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
With updated helm chart, we want the secret name to be configurable. the chart will pass the names as env var
SECRET_BOOTSTRAP_NAME