feat: Try with reranker#19
Open
GoodbyePlanet wants to merge 1 commit intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was built:
The bi-encoder (jina-embeddings-v2-base-code) already achieves Recall@5 = 100% on this codebase, meaning the correct result is always in the top 5 without any reranking. Adding a cross-encoder on top made things worse.
The root cause: both rerankers are trained on natural language pairs, not code. They don't understand code semantics well enough to improve on a purpose-built code embedding model.
Reranking would be worth revisiting if:
For now, the bi-encoder alone is the right choice.
NOTE: This will not be merged it just here for the reference.