This repository was archived by the owner on Mar 14, 2024. It is now read-only.
Conversation
✅ Deploy Preview for developer-chrome-com ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Collaborator
|
Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated. Requested changesIf there are any common problems with the content files you created or modified, they will be listed here.
|
AmySteam
added a commit
to GoogleChrome/chrome-extensions-samples
that referenced
this pull request
Apr 25, 2022
This PR moves the script tag inside of the body tag. Related GoogleChrome/developer.chrome.com#2696
AmySteam
approved these changes
Apr 25, 2022
Collaborator
AmySteam
left a comment
AmySteam
left a comment
There was a problem hiding this comment.
@jeffposnick Looks good to me 👍.
@dotproto I also made a PR to reflect this change on the tutorial code sample repo here
This comment was marked as off-topic.
This comment was marked as off-topic.
dotproto
approved these changes
Apr 26, 2022
Contributor
dotproto
left a comment
dotproto
left a comment
There was a problem hiding this comment.
Thanks for fixing this, @jeffposnick!
dotproto
pushed a commit
to GoogleChrome/chrome-extensions-samples
that referenced
this pull request
Apr 26, 2022
This PR moves the script tag inside of the body tag. Related GoogleChrome/developer.chrome.com#2696
Hattrick212
pushed a commit
to Hattrick212/Chrome-extension
that referenced
this pull request
Aug 4, 2022
This PR moves the script tag inside of the body tag. Related GoogleChrome/developer.chrome.com#2696
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2684