misc(cli): improve error if invalid value for --output argument is passed#12836
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
--output argument is passed
|
@googlebot I signed it! |
--output argument is passed--output argument is passed
lighthouse-cli/cli-flags.js
Outdated
| const validValues = strings.filter(/** @return {str is LH.OutputMode} */ str => { | ||
| if (!outputTypes.includes(str)) { | ||
| throw new Error(`"${str}" is not a valid 'output' value. ` + errorHint); | ||
| } return true; |
There was a problem hiding this comment.
nit
| } return true; | |
| } | |
| return true; |
|
hey @adamraine how can I retrigger the failed checks? |
|
@svkrclg I restarted them for ya :) |
|
Thanks @patrickhulce . |
|
Yes we are currently struggling with many node and Chromium side bugs in our tests :/ don't worry about those definitely not your doing! we're trying to sort out those issues this week. |
|
Great, thanks @patrickhulce |
Summary
Improve
--outputerror message for invalid values.Related Issues/PRs
#12787