core: add --debugNavigation setting#12902
Merged
patrickhulce merged 5 commits intomasterfrom Aug 11, 2021
Merged
Conversation
patrickhulce
requested review from
connorjclark
and removed request for
a team
connorjclark
approved these changes
Aug 10, 2021
Co-authored-by: Connor Clark <cjamcl@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a setting that keeps the page open until
continueLighthouseRun()is evaluated in the console before moving on to close gatherers so you explore the page and DevTools as long as necessary. One consequence of using this flag is that traces / network records are affected by whatever the user does, but the purpose is not to ever use the results of this run, simply to explore the page (in fact the smoketest asserts that this expands the trace window)Related Issues/PRs
fixes #12641