core(large-javascript-libraries): delete#12941
Conversation
adamraine
left a comment
adamraine
left a comment
There was a problem hiding this comment.
I was expecting all our locales to be updated, will that only happen when we do a i18n import?
|
yeah |
| "archiver": "^3.0.0", | ||
| "browserify": "^17.0.0", | ||
| "browserify-banner": "^1.0.15", | ||
| "bundle-phobia-cli": "^0.14.6", |
There was a problem hiding this comment.
shouldn't there be a yarn.lock change for this? And if there is, why doesn't git add -A && git diff --cached --exit-code catch it?
There was a problem hiding this comment.
ohhh, yarn install --frozen-lockfile leaves yarn.lock unchanged. lol whoops
There was a problem hiding this comment.
oops. let's remove that
There was a problem hiding this comment.
Interesting, --fronzen-lockfile seems to only have an error exit code when it needs to install new packages, not uninstall. It seems like any change to the yarn.lock file should trigger that, but I guess at least it's just unused modules sitting there, not missing ones?
There was a problem hiding this comment.
The first issue is the situation described by you, where
--frozen-lockfilesucceeds even if there are optimizations to be made (i.e. packages to remove). This behavior is intentional, though there are good arguments to be made that this behavior should be changed. The documentation should definitely be improved here (yarnpkg/yarn#5847), but I don't think it's a bug.
much later...
Just for clarity - was this ever fixed for Classic Yarn (1.x)? Facing this issue in 1.22.5 and I'd rather not have to migrate to v2.
1.x is frozen and will only receive security fixes, so the answer is no.
😐
|
so nice |
4 participants
fixes #12296