misc: exit collect-strings script with error code on failure#12971
Merged
connorjclark merged 4 commits intomasterfrom Aug 23, 2021
Merged
misc: exit collect-strings script with error code on failure#12971connorjclark merged 4 commits intomasterfrom
connorjclark merged 4 commits intomasterfrom
Conversation
patrickhulce
requested review from
connorjclark
and removed request for
a team
connorjclark
approved these changes
Aug 23, 2021
Contributor
|
Looks like something broke in treemap. Not sure if the failing pptr is the same underlying issue, but looking at the vercel builds, it looks like there's been a bundling problem since #12892 (see deployed treemap from that PR for what looks like the first occurrence of the #12953 also just touched the treemap UIString bundling, relevant to the changes here, and I (shameface) just relied on the pptr test and didn't check the deployed version for it either. |
| // TODO(esmodules): use dynamic import when build/ is esm. | ||
| const utilCode = fs.readFileSync(LH_ROOT + '/lighthouse-treemap/app/src/util.js', 'utf-8'); | ||
| const {UIStrings} = eval(utilCode.replace('export ', '') + '\nmodule.exports = TreemapUtil;'); | ||
| const {UIStrings} = eval(utilCode.replace(/export /g, '') + '\nmodule.exports = TreemapUtil;'); |
Collaborator
There was a problem hiding this comment.
heh, I guess this technically works.
Collaborator
Author
There was a problem hiding this comment.
Is there a different solution you had in mind?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the collect strings script was converted to be async, the script didn't also handle UnhandledPromiseRejections for an appropriate exit code (see latest master run for example). Later there was a change to move UIStrings in a way that didn't export them but we didn't catch it.
This fixes both of those two issues.
Related Issues/PRs
fixes collect strings regression from #12741
fixes string regression from #12892