This repository was archived by the owner on Mar 14, 2024. It is now read-only.
Content migration batch 9#7551
Merged
rachelandrew merged 2 commits intoGoogleChrome:mainfrom Mar 29, 2022
tokyodigitalltd:content-migration-batch-9
Merged
Content migration batch 9#7551rachelandrew merged 2 commits intoGoogleChrome:mainfrom tokyodigitalltd:content-migration-batch-9
rachelandrew merged 2 commits intoGoogleChrome:mainfrom
tokyodigitalltd:content-migration-batch-9
Conversation
Collaborator
|
Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated. Requested changesIf there are any common problems with the content files you created or modified, they will be listed here.
|
rachelandrew
suggested changes
Mar 23, 2022
Collaborator
rachelandrew
left a comment
rachelandrew
left a comment
There was a problem hiding this comment.
See comments inline
|
|
||
| - JavaScript also allows us to create, style, append, and remove new elements in the DOM. Technically, our entire page could be just one big JavaScript file that creates and styles the elements one by one. Although that would work, in practice using HTML and CSS is much easier. In the second part of our JavaScript function we create a new div element, set its text content, style it, and append it to the body. | ||
|
|
||
| <img src="images/device-js-small.png" alt="page preview"> |
Collaborator
There was a problem hiding this comment.
this image needs uploading
| Let’s start with the simplest possible case: a plain HTML page with some text | ||
| and a single image. How does the browser process this page? | ||
|
|
||
| <img src="images/full-process.png" alt="DOM construction process"> |
Collaborator
There was a problem hiding this comment.
another missing image
| - Manual tests | ||
|
|
||
| Below you'll learn which approach is relevant for each type of audit. | ||
| <br><br> |
Collaborator
There was a problem hiding this comment.
Suggested change
| <br><br> |
| <br><br> | ||
|
|
||
| {% Aside %} | ||
| <strong>Images constitute by far the |
Collaborator
There was a problem hiding this comment.
this is all in HTML, please convert to markdown.
| [remote debugging](/web/tools/chrome-devtools/remote-debugging/), | ||
| not just with device simulation. | ||
|
|
||
| <div class="note"> |
| [Pagespeed Insights](/speed/pagespeed/insights/) are useful for analyzing speed, data cost and resource usage. WebPagetest will also check static-content | ||
| caching, time to first byte, and if your site makes effective use of CDNs. | ||
|
|
||
| {% Aside %} |
Collaborator
There was a problem hiding this comment.
convert HTML to markdown
| <figure> | ||
| {% Img src="image/C47gYyWYVMMhDmtYSLOWazuyePF2/jw1eTOeLv1S7jqrgQxlU.png", alt="Screenshot showing Google Analytics Site Speed", width="800", height="417" %} | ||
| </figure> | ||
| <br> |
Collaborator
There was a problem hiding this comment.
Suggested change
| <br> |
| [Site Speed](https://support.google.com/analytics/answer/1205784) to check how | ||
| performance metrics correlate with business metrics. For example: 'how fast did the homepage load?' | ||
| compared to 'did entry via the home page result in a sale?' | ||
| <br><br> |
Collaborator
There was a problem hiding this comment.
Suggested change
| <br><br> |
Collaborator
|
@mattletford this one still has a bunch of changes to tidy up so we can get it merged. |
rachelandrew
approved these changes
Mar 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrating content
https://developers.google.com/web/fundamentals/performance/audit/tools
https://web.dev/performance-audit-tools
https://developers.google.com/web/fundamentals/performance/critical-rendering-path/adding-interactivity-with-javascript
https://web.dev/critical-rendering-path-adding-interactivity-with-javascript
https://developers.google.com/web/fundamentals/performance/critical-rendering-path/analyzing-crp
https://web.dev/critical-rendering-path-analyzing-crp
https://developers.google.com/web/fundamentals/performance/critical-rendering-path/constructing-the-object-model
https://web.dev/critical-rendering-path-constructing-the-object-model
https://developers.google.com/web/fundamentals/performance/critical-rendering-path/measure-crp
https://web.dev/critical-rendering-path-measure-crp
@rachelandrew