This repository was archived by the owner on Mar 14, 2024. It is now read-only.
ContentMigrationBatch#SH5R1#7838
Merged
rachelandrew merged 5 commits intoGoogleChrome:mainfrom May 10, 2022
tokyodigitalltd:H5RBatch1
Merged
ContentMigrationBatch#SH5R1#7838rachelandrew merged 5 commits intoGoogleChrome:mainfrom tokyodigitalltd:H5RBatch1
rachelandrew merged 5 commits intoGoogleChrome:mainfrom
tokyodigitalltd:H5RBatch1
Conversation
rachelandrew
suggested changes
May 5, 2022
Collaborator
rachelandrew
left a comment
There was a problem hiding this comment.
I think the typo in 'layout' (I fixed two but the others are the same) is the reason for the weird errors in the tests, if you can fix them all we can take a look.
| @@ -0,0 +1,335 @@ | |||
| --- | |||
| layou: post | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| layou: post | |
| layout: post |
| @@ -0,0 +1,318 @@ | |||
| --- | |||
| layou: post | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| layou: post | |
| layout: post |
Contributor
Author
There was a problem hiding this comment.
@rachelandrew oh, sorry about that. They were displaying ok on my local and I didn't pick up the typo. I apologise. Let me know if they're ok now.
Collaborator
|
Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated. Requested changesIf there are any common problems with the content files you created or modified, they will be listed here.
|
rachelandrew
approved these changes
May 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.html5rocks.com/en/tutorials/appcache/beginner/
https://www.html5rocks.com/en/tutorials/async/deferred/
https://www.html5rocks.com/en/tutorials/audio/quick/
https://www.html5rocks.com/en/tutorials/audio/scheduling/
https://www.html5rocks.com/en/tutorials/canvas/hidpi/
@rachelandrew