Skip to content
This repository was archived by the owner on Mar 14, 2024. It is now read-only.

ContentMigrationBatch#SH5R1#7838

Merged
rachelandrew merged 5 commits intoGoogleChrome:mainfrom
tokyodigitalltd:H5RBatch1
May 10, 2022
Merged

ContentMigrationBatch#SH5R1#7838
rachelandrew merged 5 commits intoGoogleChrome:mainfrom
tokyodigitalltd:H5RBatch1

Conversation

@rachelandrew rachelandrew added the $-presubmit Add label to run presubmit tests. label May 5, 2022
Copy link
Copy Markdown
Collaborator

@rachelandrew rachelandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the typo in 'layout' (I fixed two but the others are the same) is the reason for the weird errors in the tests, if you can fix them all we can take a look.

@@ -0,0 +1,335 @@
---
layou: post
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
layou: post
layout: post

@@ -0,0 +1,318 @@
---
layou: post
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
layou: post
layout: post

Copy link
Copy Markdown
Contributor Author

@simgobb simgobb May 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rachelandrew oh, sorry about that. They were displaying ok on my local and I didn't pick up the typo. I apologise. Let me know if they're ok now.

@chrome-devrel-review-bot
Copy link
Copy Markdown
Collaborator

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

src/site/content/en/blog/appcache-beginner/index.md

  • Please put a blank line before and after each section heading. Some Markdown parsers don't detect the text as a section heading unless there is blank space before and after it. Affected lines: 12
  • Please change your usage of the following words:
    • Do not use master. Affected lines: 119

src/site/content/en/blog/async-deferred/index.md

src/site/content/en/blog/audio-quick/index.md

  • This file passed all of our automated Markdown audits.

src/site/content/en/blog/audio-scheduling/index.md

  • Please put a blank line before and after each section heading. Some Markdown parsers don't detect the text as a section heading unless there is blank space before and after it. Affected lines: 12

src/site/content/en/blog/canvas-hidipi/index.md

  • This file passed all of our automated Markdown audits.

@rachelandrew rachelandrew added $-presubmit Add label to run presubmit tests. and removed $-presubmit Add label to run presubmit tests. labels May 5, 2022
@simgobb simgobb closed this May 6, 2022
@simgobb simgobb reopened this May 6, 2022
@rachelandrew rachelandrew added $-presubmit Add label to run presubmit tests. and removed $-presubmit Add label to run presubmit tests. labels May 10, 2022
@rachelandrew rachelandrew merged commit 9eced69 into GoogleChrome:main May 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

$-presubmit Add label to run presubmit tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants