This repository was archived by the owner on Mar 14, 2024. It is now read-only.
Merged
Conversation
✅ Deploy Preview for web-dev-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Collaborator
|
Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated. Requested changesIf there are any common problems with the content files you created or modified, they will be listed here.
|
1 similar comment
Collaborator
|
Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated. Requested changesIf there are any common problems with the content files you created or modified, they will be listed here.
|
umaar
reviewed
May 24, 2022
src/site/content/en/web-dev-basics-one/js-libraries-vs-frameworks/index.md
Show resolved
Hide resolved
src/site/content/en/web-dev-basics-one/js-libraries-vs-frameworks/index.md
Outdated
Show resolved
Hide resolved
src/site/content/en/web-dev-basics-one/js-libraries-vs-frameworks/index.md
Outdated
Show resolved
Hide resolved
src/site/content/en/web-dev-basics-one/js-libraries-vs-frameworks/index.md
Outdated
Show resolved
Hide resolved
src/site/content/en/web-dev-basics-one/js-libraries-vs-frameworks/index.md
Outdated
Show resolved
Hide resolved
src/site/content/en/web-dev-basics-one/js-libraries-vs-frameworks/index.md
Outdated
Show resolved
Hide resolved
src/site/content/en/web-dev-basics-one/js-libraries-vs-frameworks/index.md
Outdated
Show resolved
Hide resolved
src/site/content/en/web-dev-basics-one/js-libraries-vs-frameworks/index.md
Outdated
Show resolved
Hide resolved
src/site/content/en/web-dev-basics-one/js-libraries-vs-frameworks/index.md
Show resolved
Hide resolved
Co-authored-by: Umar Hansa <umar.hansa@gmail.com>
umaar
reviewed
May 25, 2022
Contributor
umaar
left a comment
umaar
left a comment
There was a problem hiding this comment.
One last issue (from me) with a template interpolation issue which invalidates a code sample. Apart from that, LGTM!
src/site/content/en/web-dev-basics-one/js-libraries-vs-frameworks/index.md
Outdated
Show resolved
Hide resolved
…rks/index.md Co-authored-by: Umar Hansa <umar.hansa@gmail.com>
Collaborator
Author
|
@umaar can you take a look at this one now? |
Contributor
|
Nice, can see it fixed on the preview URL. LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7840
Another of the pieces of content we are hosting for the ETT course.
Preview: https://deploy-preview-7975--web-dev-staging.netlify.app/js-libraries-vs-frameworks/