Skip to content
This repository was archived by the owner on Mar 14, 2024. It is now read-only.

Learn Accessibility (Ch 04, 14, 15)#9154

Merged
alexandrascript merged 37 commits intomainfrom
aaron-learn-accessibility
Dec 6, 2022
Merged

Learn Accessibility (Ch 04, 14, 15)#9154
alexandrascript merged 37 commits intomainfrom
aaron-learn-accessibility

Conversation

@AaronForinton
Copy link
Copy Markdown
Contributor

@AaronForinton AaronForinton commented Dec 2, 2022

@AaronForinton AaronForinton added the DO NOT MERGE Actively working on but experimental label Dec 2, 2022
@netlify
Copy link
Copy Markdown

netlify bot commented Dec 2, 2022

Deploy Preview for web-dev-staging ready!

Name Link
🔨 Latest commit 5cf3b1e
🔍 Latest deploy log https://app.netlify.com/sites/web-dev-staging/deploys/638e76b32cc8df000950ad31
😎 Deploy Preview https://deploy-preview-9154--web-dev-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rachelandrew
Copy link
Copy Markdown
Collaborator

@AaronForinton there was a comma inside rather than outside the quotes in an image just after the error. @philipwalton pointed out in chat that the error was off by the number of lines in the YAML frontmatter, which is guess is removed before the build runs.

@AaronForinton
Copy link
Copy Markdown
Contributor Author

AaronForinton commented Dec 2, 2022

@AaronForinton there was a comma inside rather than outside the quotes in an image just after the error. @philipwalton pointed out in chat that the error was off by the number of lines in the YAML frontmatter, which is guess is removed before the build runs.

Thank you! Very helpful to know about the frontmatter

These are ready to review now.

@AaronForinton AaronForinton removed the DO NOT MERGE Actively working on but experimental label Dec 2, 2022
@alexandrascript
Copy link
Copy Markdown
Contributor

@AaronForinton thanks so much for getting this draft up. I'm making some changes, and I want to highlight them for future Learn coursework.

The first is to refer to the Components section of the handbook. There are a few examples, like the "Don't do this" vs. "Do this" which have a specific design to use (the Compare component); Tables have a <div> wrapper; and Codepens which have further special requirements.

Codepens should be forked into a web dev account. I'll make sure to have included that in the google docs in the future, like I did for the images.

# Original codepen
{% Codepen {
user: 'cariefisher',
id: 'wvXejPv'
} %}

# New codepen 
{% Codepen {
 user: 'web-dev-codepen-external',
 id: 'jOKXLyv',
 height: 350,
 theme: 'auto',
 tab: 'html,result'
} %}

@AaronForinton
Copy link
Copy Markdown
Contributor Author

Thanks for the fixes @heyawhite. I'd completely missed some of the things on the components page! I've bookmarked + I'll be able to properly implement everything in future.

@alexandrascript
Copy link
Copy Markdown
Contributor

@AaronForinton I've been here a year and I'm still discovering new ones :)

questions:
- type: multiple-choice
cardinality: "1"
correctAnswers: "2"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
correctAnswers: "2"
correctAnswers: "1"

@AaronForinton some more fun to be aware of. The options count starts with 0. So, because the correct answer is "Use JavaScript to toggle an element’s class, and add the style to your CSS stylesheet", it should be 1

@alexandrascript alexandrascript added the content Issues related to content label Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

content Issues related to content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants